ci: Unblocking ADO build pipeline #3860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ADO build pipeline by removing references to the non-existent "acn-devops" repository and simplifying the pipeline configuration to use local templates and resources instead.
- Removes dependency on external "acn-devops" repository that was blocking the pipeline
- Streamlines pipeline configuration by using local templates and artifacts
- Includes build fixes for ARM64 architecture and manifest generation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .pipelines/run-pipeline.yaml | Major refactor removing acn-devops dependency and simplifying stage configuration |
| .pipelines/build/ob-prepare.steps.yaml | Updates artifact handling and template references to use local resources |
| .pipelines/build/images.jobs.yaml | Enables ARM64 host architecture and removes unnecessary QEMU settings |
| .pipelines/build/image.steps.yaml | Adds provenance false flag to Docker build parameters |
| .pipelines/build/generate-manifest.steps.yaml | Fixes manifest argument handling by properly joining array elements |
Comments suppressed due to low confidence (1)
.pipelines/run-pipeline.yaml:15
- The variable name 'ACR_DIR' is misleading as it appears to reference Azure Container Registry but actually points to the source directory. Consider renaming to 'ACN_SOURCE_DIR' or similar to match the pattern used elsewhere.
ACR_DIR: $(Build.SourcesDirectory)/azure-container-networking
rohitams
reviewed
Jul 28, 2025
rohitams
reviewed
Jul 28, 2025
jpayne3506
approved these changes
Jul 28, 2025
Contributor
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
rohitams
approved these changes
Jul 28, 2025
NihaNallappagari
pushed a commit
to NihaNallappagari/azure-container-networking
that referenced
this pull request
Sep 4, 2025
* Revert "Use Separate Version for Build vs. Source (Azure#3751)" This reverts commit 948a40f. * Test * Test * Test * Unblocking build pipeline
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The ADO build pipeline is currently blocked with a reference to a "acn-devops" repo which is not refenced in the main pipeline file (in the ADO repository).
This PR reverts this reference. It also implements a fix for a building all the images in the OneBranch ADO pipeline.
Issue Fixed:
No GitHub issue associated to this PR.
Requirements:
Notes: